Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly locate common proto files #46

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Correctly locate common proto files #46

merged 4 commits into from
Jun 18, 2018

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus mentioned this pull request Jun 18, 2018
Closed
@codecov-io
Copy link

codecov-io commented Jun 18, 2018 •
edited
Loading

Codecov Report

Merging #46 into master will increase coverage by 1.14%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #46      +/-   ##
=======================================
+ Coverage   82.85%   84%   +1.14%     
=======================================
  Files           3     3              
  Lines          70    75       +5     
=======================================
+ Hits           58    63       +5     
  Misses         12    12
Impacted Files Coverage Δ
load.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782ccc6...281bc70. Read the comment docs.

JustinBeckwith
JustinBeckwith approved these changes Jun 18, 2018
View reviewed changes
.gitignore
@@ -8,3 +8,4 @@ system-test/secrets.js
system-test/*key.json
*.lock
*-lock.js*
google/

This comment was marked as spam.

Sign in to view

@JustinBeckwith
Copy link
Contributor

@stephenplusplus thank you for doing this 😸

crwilcox
crwilcox reviewed Jun 18, 2018
View reviewed changes
.jsdoc.js
source: {
excludePattern: '(^|\\/|\\\\)[._]',
include: [

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

crwilcox
crwilcox approved these changes Jun 18, 2018
View reviewed changes
load.js
// Causes the loading of an included proto to check if it is a common
// proto. If it is a common proto, use the google-proto-files proto.
resolvePath(_, includePath) {
includePath = path.normalize(includePath);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus merged commit 3854fcd into googleapis:master Jun 18, 2018
@stephenplusplus stephenplusplus deleted the spp--load-bug branch June 18, 2018 21:59
@stephenplusplus stephenplusplus mentioned this pull request Jun 18, 2018
Merged
stephenplusplus added a commit that referenced this pull request Jun 19, 2018
@stephenplusplus
0.16.1 (#47)
49a57a0 
## Fixes

- (#46) Correctly locate common proto files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@crwilcox crwilcox crwilcox approved these changes

@landrito landrito Awaiting requested review from landrito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @codecov-io @JustinBeckwith @crwilcox